Am 18.12.19 um 04:50 schrieb Pan Zhang:
this set adds support for removal of gpu drm dead code.

patch2:
`num_entries` is a data of unsigned type(compilers always treat as unsigned 
int) and SIZE_MAX == ~0,

so there is a impossible condition:
'(num_entries > ((~0) - 56) / 72) => (max(0-u32) > 256204778801521549)'.

NAK, that calculation is not correct on 32-bit systems.

Christian.


Signed-off-by: Pan Zhang <zhangpa...@huawei.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
index 85b0515..10a7f30 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
@@ -71,10 +71,6 @@ int amdgpu_bo_list_create(struct amdgpu_device *adev, struct 
drm_file *filp,
        unsigned i;
        int r;
- if (num_entries > (SIZE_MAX - sizeof(struct amdgpu_bo_list))
-                               / sizeof(struct amdgpu_bo_list_entry))
-               return -EINVAL;
-
        size = sizeof(struct amdgpu_bo_list);
        size += num_entries * sizeof(struct amdgpu_bo_list_entry);
        list = kvmalloc(size, GFP_KERNEL);

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to