-----Original Message----- From: Chen, Guchun <guchun.c...@amd.com> Sent: Wednesday, November 27, 2019 5:50 PM To: Ma, Le <le...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking <hawking.zh...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>; Li, Dennis <dennis...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>; Ma, Le <le...@amd.com> Subject: RE: [PATCH 10/10] drm/amdgpu: reduce redundant uvd context lost warning message [AMD Official Use Only - Internal Distribution Only] -----Original Message----- From: Le Ma <le...@amd.com<mailto:le...@amd.com>> Sent: Wednesday, November 27, 2019 5:15 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Cc: Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>; Chen, Guchun <guchun.c...@amd.com<mailto:guchun.c...@amd.com>>; Zhou1, Tao <tao.zh...@amd.com<mailto:tao.zh...@amd.com>>; Li, Dennis <dennis...@amd.com<mailto:dennis...@amd.com>>; Deucher, Alexander <alexander.deuc...@amd.com<mailto:alexander.deuc...@amd.com>>; Ma, Le <le...@amd.com<mailto:le...@amd.com>> Subject: [PATCH 10/10] drm/amdgpu: reduce redundant uvd context lost warning message Move the print out of uvd instance loop in amdgpu_uvd_suspend Change-Id: Ifad997debd84763e1b55d668e144b729598f115e Signed-off-by: Le Ma <le...@amd.com<mailto:le...@amd.com>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c index e324bfe..ac7c7795 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c @@ -377,12 +377,15 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev) /* re-write 0 since err_event_athub will corrupt VCPU buffer */ if (amdgpu_ras_intr_triggered()) { - DRM_WARN("UVD VCPU state may lost due to RAS ERREVENT_ATHUB_INTERRUPT\n"); memset(adev->uvd.inst[j].saved_bo, 0, size); } else { memcpy_fromio(adev->uvd.inst[j].saved_bo, ptr, size); } } + + if (amdgpu_ras_intr_triggered()) { + DRM_WARN("UVD VCPU state may lost due to RAS ERREVENT_ATHUB_INTERRUPT\n"); + [Guchun]the "{" after the if condition needs to be removed? [Le] Yes, sent it too quickly and made a mistake here. return 0; } -- 2.7.4
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
