Sure，will do that！ Thanks， Jack
Outlook for Android<https://aka.ms/ghei36> ________________________________ From: Deucher, Alexander <alexander.deuc...@amd.com> Sent: Friday, November 22, 2019 12:00:04 AM To: Zhang, Jack (Jian) <jack.zha...@amd.com>; Alex Deucher <alexdeuc...@gmail.com> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 2/2] drm/amd/amdgpu/sriov skip RLCG s/r list for arcturus VF. You can have my RB on the first patch if you fix the compiler warnings. Alex ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Zhang, Jack (Jian) <jack.zha...@amd.com> Sent: Thursday, November 21, 2019 10:58 AM To: Alex Deucher <alexdeuc...@gmail.com> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 2/2] drm/amd/amdgpu/sriov skip RLCG s/r list for arcturus VF. Thanks Alex for this review. Both of the two patches will not influence bare-metal code path. B. R. Jack Outlook for Android<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Faka.ms%2Fghei36&data=02%7C01%7Calexander.deucher%40amd.com%7Cf350a586b8b840526a2c08d76e9bb538%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637099487450051533&sdata=ghsxwJqO5AO%2B2pBhPoQz70SkyYyeNCnA5FQMAHQVVpI%3D&reserved=0> ________________________________ From: Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, November 21, 2019 11:26:37 PM To: Zhang, Jack (Jian) <jack.zha...@amd.com> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 2/2] drm/amd/amdgpu/sriov skip RLCG s/r list for arcturus VF. Nevermind. I missed the sr-iov check. Patch is: Acked-by: Alex Deucher <alexander.deuc...@amd.com> On Thu, Nov 21, 2019 at 10:25 AM Alex Deucher <alexdeuc...@gmail.com> wrote: > > Won't this impact bare metal hw that needs this? > > Alex > > On Thu, Nov 21, 2019 at 1:17 AM Jack Zhang <jack.zha...@amd.com> wrote: > > > > After rlcg fw 2.1, kmd driver starts to load extra fw for > > LIST_CNTL,GPM_MEM,SRM_MEM. We needs to skip the three fw > > because all rlcg related fw have been loaded by host driver. > > Guest driver would load the three fw fail without this change. > > > > Signed-off-by: Jack Zhang <jack.zha...@amd.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > index c3a42d3..eecde80 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > > @@ -1470,7 +1470,10 @@ static int psp_np_fw_load(struct psp_context *psp) > > || ucode->ucode_id == AMDGPU_UCODE_ID_SDMA5 > > || ucode->ucode_id == AMDGPU_UCODE_ID_SDMA6 > > || ucode->ucode_id == AMDGPU_UCODE_ID_SDMA7 > > - || ucode->ucode_id == AMDGPU_UCODE_ID_RLC_G)) > > + || ucode->ucode_id == AMDGPU_UCODE_ID_RLC_G > > + || ucode->ucode_id == > > AMDGPU_UCODE_ID_RLC_RESTORE_LIST_CNTL > > + || ucode->ucode_id == > > AMDGPU_UCODE_ID_RLC_RESTORE_LIST_GPM_MEM > > + || ucode->ucode_id == > > AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM)) > > /*skip ucode loading in SRIOV VF */ > > continue; > > > > -- > > 2.7.4 > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@lists.freedesktop.org > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CJack.Zhang1%40amd.com%7C62c30b71b3b8490862d808d76e973ae5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637099468112639673&sdata=iC932sWNGrLeexp7wIDdrZ7cjVBcFv5giOTC3uHdE%2Fk%3D&reserved=0<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7Cf350a586b8b840526a2c08d76e9bb538%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637099487450061527&sdata=FofOoED2ixVkMukh%2FOXH8mdtu%2B%2BwilXYGxbQVNRflUY%3D&reserved=0>
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
