Thanks! Reviewed-by: Evan Quan <evan.q...@amd.com>
> -----Original Message-----
> From: Colin King <colin.k...@canonical.com>
> Sent: Monday, August 05, 2019 6:30 PM
> To: Rex Zhu <rex....@amd.com>; Quan, Evan <evan.q...@amd.com>;
> Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian
> <christian.koe...@amd.com>; Zhou, David(ChunMing)
> <david1.z...@amd.com>; David Airlie <airl...@linux.ie>; Daniel Vetter
> <dan...@ffwll.ch>; amd-gfx@lists.freedesktop.org; dri-
> de...@lists.freedesktop.org
> Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: [PATCH][drm-next] drm/amd/powerplay: remove redundant
> duplicated return check
>
> From: Colin Ian King <colin.k...@canonical.com>
>
> The check on ret is duplicated in two places, it is redundant code.
> Remove it.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: b94afb61cdae ("drm/amd/powerplay: honor hw limit on fetching
> metrics data for navi10")
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
> drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> index d62c2784b102..b272c8dc8f79 100644
> --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> @@ -941,8 +941,6 @@ static int navi10_get_gpu_power(struct smu_context
> *smu, uint32_t *value)
> ret = navi10_get_metrics_table(smu, &metrics);
> if (ret)
> return ret;
> - if (ret)
> - return ret;
>
> *value = metrics.AverageSocketPower << 8;
>
> @@ -1001,8 +999,6 @@ static int navi10_get_fan_speed_rpm(struct
> smu_context *smu,
> ret = navi10_get_metrics_table(smu, &metrics);
> if (ret)
> return ret;
> - if (ret)
> - return ret;
>
> *speed = metrics.CurrFanSpeed;
>
> --
> 2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
