On Tue, Jul 9, 2019 at 9:17 PM Quan, Evan <evan.q...@amd.com> wrote: > > Hi Alex, > > > > There are actually two MAX_USEC_TIMEOUT related macros. > > AMD_MAX_USEC_TIMEOUT is used for SMU and AMDGPU_MAX_USEC_TIMEOUT is used > widely in other parts. > > Maybe you mistreated it as AMDGPU_MAX_USEC_TIMEOUT. I was confused by them > too. > > > > drivers/gpu/drm/amd/include/amd_shared.h:29:#define AMD_MAX_USEC_TIMEOUT > 200000 /* 200 ms */ > > drivers/gpu/drm/amd/amdgpu/amdgpu.h:179:#define AMDGPU_MAX_USEC_TIMEOUT > 100000 /* 100 ms */ > > > > I’m considering to sort these timeout settings up later. Maybe to combine > them as one or give them differentiated names. > >
Indeed. I was mixing them up. We should clarify those. Patch is: Acked-by: Alex Deucher <alexander.deuc...@amd.com> > > Regards, > > Evan > > From: Deucher, Alexander <alexander.deuc...@amd.com> > Sent: Tuesday, July 09, 2019 8:41 PM > To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org > Cc: Grodzovsky, Andrey <andrey.grodzov...@amd.com>; Wu, Xiaowei > <xiaowei...@amd.com> > Subject: Re: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting > time > > > > If this is just for the SMU, maybe it would be better to add a separate > timeout for the SMU since this will increase the timeout for lots of things, > unless we need an overall timeout increase for mode1 reset. > > > > Alex > > ________________________________ > > From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Evan Quan > <evan.q...@amd.com> > Sent: Tuesday, July 9, 2019 1:41 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander; Grodzovsky, Andrey; Quan, Evan; Wu, Xiaowei > Subject: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time > > > > Increase the waiting time to 1s from 200ms. This is expected > to fix some mode1 reset failures. > > Change-Id: I4c11996628cd40d559c6edea97d092f397122d78 > Signed-off-by: Evan Quan <evan.q...@amd.com> > --- > drivers/gpu/drm/amd/include/amd_shared.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/include/amd_shared.h > b/drivers/gpu/drm/amd/include/amd_shared.h > index 447bc4d..779c9e7 100644 > --- a/drivers/gpu/drm/amd/include/amd_shared.h > +++ b/drivers/gpu/drm/amd/include/amd_shared.h > @@ -28,7 +28,7 @@ > #endif > > > -#define AMD_MAX_USEC_TIMEOUT 200000 /* 200 ms */ > +#define AMD_MAX_USEC_TIMEOUT 1000000 /* 1000 ms */ > > /* > * Chip flags > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
