On Sat, Jun 22, 2019 at 11:03:14AM +0800, Mao Wenan wrote:
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> index 0e6dba9..0bf4dd9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> @@ -246,12 +246,10 @@ static int init_pmu_by_type(struct amdgpu_device *adev,
> /* init amdgpu_pmu */
> int amdgpu_pmu_init(struct amdgpu_device *adev)
> {
> - int ret = 0;
> -
> switch (adev->asic_type) {
> case CHIP_VEGA20:
> /* init df */
> - ret = init_pmu_by_type(adev, df_v3_6_attr_groups,
> + init_pmu_by_type(adev, df_v3_6_attr_groups,
> "DF", "amdgpu_df", PERF_TYPE_AMDGPU_DF,
> DF_V3_6_MAX_COUNTERS);
You're resending this for other reasons, but don't forget to update the
indenting on the arguments so they still line up with the '('.
regards,
dan carpenter
