Hi Felix,

I can (v2) the patch I sent to the list. Ultimately a build warning alone I think is the wrong approach.

Cheers,
Tom

On 07/03/2018 12:13 PM, Felix Kuehling wrote:

On 2018-07-03 10:19 AM, Tom St Denis wrote:
Hi all,

This block

#if defined(CONFIG_DRM_AMD_DC)
         else if (amdgpu_device_has_dc_support(adev))
             amdgpu_device_ip_block_add(adev, &dm_ip_block);
#else
#    warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15."
#endif


in soc15_set_ip_blocks() should probably be ported to a runtime
drm_warn() no?  This means a kernel with no DC support will just
silently fail to light up on SOC15.

I can write a patch for this if nobody objects.

Maybe do both. So someone building a kernel without DC gets a warning as
well as someone running it.

Regards,
   Felix



(found this while trying to sort out the PP get_clocks call for my
Raven1 ...).

Tom
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to