It might be good to understand why validate fails.

Signed-off-by: Harry Wentland <harry.wentl...@amd.com>
Reviewed-by: Tony Cheng <tony.ch...@amd.com>
Acked-by: Harry Wentland <harry.wentl...@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 6fc4ded80b19..5590ef80e644 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2832,6 +2832,7 @@ int amdgpu_dm_connector_mode_valid(struct drm_connector 
*connector,
        /* TODO: Unhardcode stream count */
        struct dc_stream_state *stream;
        struct amdgpu_dm_connector *aconnector = 
to_amdgpu_dm_connector(connector);
+       enum dc_status dc_result = DC_OK;
 
        if ((mode->flags & DRM_MODE_FLAG_INTERLACE) ||
                        (mode->flags & DRM_MODE_FLAG_DBLSCAN))
@@ -2864,8 +2865,15 @@ int amdgpu_dm_connector_mode_valid(struct drm_connector 
*connector,
        stream->src.height = mode->vdisplay;
        stream->dst = stream->src;
 
-       if (dc_validate_stream(adev->dm.dc, stream) == DC_OK)
+       dc_result = dc_validate_stream(adev->dm.dc, stream);
+
+       if (dc_result == DC_OK)
                result = MODE_OK;
+       else
+               DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation\n",
+                             mode->vdisplay,
+                             mode->hdisplay,
+                             mode->clock);
 
        dc_stream_release(stream);
 
-- 
2.14.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to