Applied the series. Thanks! Alex
On Wed, Dec 24, 2025 at 10:06 AM Marco Crivellari <[email protected]> wrote: > > This patch continues the effort to refactor workqueue APIs, which has begun > with the changes introducing new workqueues and a new alloc_workqueue flag: > > commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") > commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") > > The point of the refactoring is to eventually alter the default behavior of > workqueues to become unbound by default so that their workload placement is > optimized by the scheduler. > > Before that to happen after a careful review and conversion of each individual > case, workqueue users must be converted to the better named new workqueues > with > no intended behaviour changes: > > system_wq -> system_percpu_wq > system_unbound_wq -> system_dfl_wq > > This way the old obsolete workqueues (system_wq, system_unbound_wq) can be > removed in the future. > > Suggested-by: Tejun Heo <[email protected]> > Signed-off-by: Marco Crivellari <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/aldebaran.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/aldebaran.c > b/drivers/gpu/drm/amd/amdgpu/aldebaran.c > index daa7b23bc775..a7bc65099755 100644 > --- a/drivers/gpu/drm/amd/amdgpu/aldebaran.c > +++ b/drivers/gpu/drm/amd/amdgpu/aldebaran.c > @@ -179,7 +179,7 @@ aldebaran_mode2_perform_reset(struct amdgpu_reset_control > *reset_ctl, > list_for_each_entry(tmp_adev, reset_device_list, reset_list) { > /* For XGMI run all resets in parallel to speed up the > process */ > if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) { > - if (!queue_work(system_unbound_wq, > + if (!queue_work(system_dfl_wq, > &tmp_adev->reset_cntl->reset_work)) > r = -EALREADY; > } else > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 12201b8e99b3..2ee416c36ca3 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -6173,7 +6173,7 @@ int amdgpu_do_asic_reset(struct list_head > *device_list_handle, > list_for_each_entry(tmp_adev, device_list_handle, reset_list) > { > /* For XGMI run all resets in parallel to speed up > the process */ > if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) { > - if (!queue_work(system_unbound_wq, > + if (!queue_work(system_dfl_wq, > &tmp_adev->xgmi_reset_work)) > r = -EALREADY; > } else > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c > index 28c4ad62f50e..9c4631608526 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c > @@ -116,7 +116,7 @@ static int amdgpu_reset_xgmi_reset_on_init_perform_reset( > /* Mode1 reset needs to be triggered on all devices together */ > list_for_each_entry(tmp_adev, reset_device_list, reset_list) { > /* For XGMI run all resets in parallel to speed up the > process */ > - if (!queue_work(system_unbound_wq, > &tmp_adev->xgmi_reset_work)) > + if (!queue_work(system_dfl_wq, &tmp_adev->xgmi_reset_work)) > r = -EALREADY; > if (r) { > dev_err(tmp_adev->dev, > -- > 2.52.0 >
