Re: [PATCH 1/3] drm/amd/pm: fix memleak issue in smu_v15_0_8_get_gpu_metrics()

[Alex Deucher]

On Mon, Mar 30, 2026 at 11:09 PM Yang Wang <kevinyang.w...@amd.com> wrote:
>
> remove unsued code to avoid memleak issue.
> (NOTE: This bug occurs during internal branch switching)
>
> Fixes: 60c033841eb9 ("drm/amd/pm: add get_gpu_metrics support for 15.0.8")
>
> Signed-off-by: Yang Wang <kevinyang.w...@amd.com>

Acked-by: Alex Deucher <alexander.deuc...@amd.com>

> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c 
> b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> index 89a44b456e8a..b158be7cd7bc 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
> @@ -1601,8 +1601,6 @@ static ssize_t smu_v15_0_8_get_gpu_metrics(struct 
> smu_context *smu, void **table
>         uint32_t mid_mask = adev->aid_mask;
>         MetricsTable_t *metrics;
>
> -       metrics = kzalloc(sizeof(MetricsTable_t), GFP_KERNEL);
> -
>         ret = smu_v15_0_8_get_metrics_table_internal(smu, 1, NULL);
>         if (ret)
>                 return ret;
> --
> 2.47.3
>