Re: [PATCH v2 1/3] drm/amd/pm: Add common smu fw check function

[Lazar, Lijo]

On 12-Mar-26 3:57 PM, Asad Kamal wrote:
Add common smu firmware version check function

Signed-off-by: Asad Kamal <asad.ka...@amd.com>
---
  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 33 ++++++++++++++++++++++++++
  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h |  1 +
  2 files changed, 34 insertions(+)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 326c86b920a2..432ff30dbbd5 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -1035,6 +1035,39 @@ int smu_cmn_get_smc_version(struct smu_context *smu,
        return ret;
  }
  
+int smu_cmn_check_fw_version(struct smu_context *smu)
+{
+       struct amdgpu_device *adev = smu->adev;
+       uint32_t if_version = 0xff, smu_version = 0xff;
+       uint8_t smu_program, smu_major, smu_minor, smu_debug;
+       int ret;
+
+       ret = smu_cmn_get_smc_version(smu, &if_version, &smu_version);
+       if (ret)
+               return ret;
+
+       smu_program = (smu_version >> 24) & 0xff;
+       smu_major = (smu_version >> 16) & 0xff;
+       smu_minor = (smu_version >> 8) & 0xff;
+       smu_debug = (smu_version >> 0) & 0xff;
+       adev->pm.fw_version = smu_version;
+
+       if (adev->pm.fw)
+               dev_dbg(adev->dev, "smu fw reported program %d, version = 0x%08x 
(%d.%d.%d)\n",
+                       smu_program, smu_version, smu_major, smu_minor, 
smu_debug);
+

Since version is printed once during load, this may be removed as well. 
That aside series is -

Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

Thanks,
Lijo

+       dev_info_once(adev->dev, "smu driver if version = 0x%08x, smu fw if version 
= 0x%08x, "
+                     "smu fw program = %d, smu fw version = 0x%08x 
(%d.%d.%d)\n",
+                     smu->smc_driver_if_version, if_version,
+                     smu_program, smu_version, smu_major, smu_minor, 
smu_debug);
+
+       if (smu->smc_driver_if_version != SMU_IGNORE_IF_VERSION &&
+           if_version != smu->smc_driver_if_version)
+               dev_info(adev->dev, "SMU driver if version not matched\n");
+
+       return 0;
+}
+
  int smu_cmn_update_table(struct smu_context *smu,
                         enum smu_table_id table_index,
                         int argument,
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h 
b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h
index b7bfddc65fb2..e4d282d8bcae 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h
@@ -207,6 +207,7 @@ int smu_cmn_print_pcie_levels(struct smu_context *smu,
  
  int smu_cmn_dpm_pcie_gen_idx(int gen);
  int smu_cmn_dpm_pcie_width_idx(int width);
+int smu_cmn_check_fw_version(struct smu_context *smu);
  
  /*SMU gpu metrics */