Re: [PATCH] drm/amdgpu: Drop unreachable return in amdgpu_reg_get_smn_base64()

[Lazar, Lijo]

On 12-Mar-26 2:22 PM, Srinivasan Shanmugam wrote:

amdgpu_reg_get_smn_base64() returns from all control-flow paths inside
the !adev->reg.smn.get_smn_base fallback path.

For version == 1, the function returns the base address from
amdgpu_reg_smn_v1_0_get_base(). For all other versions, the default
switch branch emits a dev_err_once() and returns 0.

The trailing return 0 after the switch is therefore unreachable and is
reported by Smatch as dead code:

   drivers/gpu/drm/amd/amdgpu/amdgpu_reg_access.c:317
   amdgpu_reg_get_smn_base64() warn: ignoring unreachable code

Remove the redundant return statement.

Cc: Dan Carpenter <dan.carpen...@linaro.org>
Cc: Lijo Lazar <lijo.la...@amd.com>
Cc: Hawking Zhang <hawking.zh...@amd.com>
Cc: Alex Deucher <alexander.deuc...@amd.com>
Cc: Christian König <christian.koe...@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmu...@amd.com>

Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

Thanks,
Lijo

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_reg_access.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reg_access.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_reg_access.c
index bf8645390bdc..540040c76058 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reg_access.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reg_access.c
@@ -314,7 +314,6 @@ uint64_t amdgpu_reg_get_smn_base64(struct amdgpu_device 
*adev,
                                "SMN base address query not supported for this 
device\n");
                        return 0;
                }
-               return 0;
        }
        return adev->reg.smn.get_smn_base(adev, block, die_inst);
  }