On 3/6/26 09:08, Sunil Khatri wrote: > Below is the warning thrown by the clang compiler: > linux/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:588:9: warning: > format string is not a string literal (potentially insecure) > [-Wformat-security] > stats_dir_filename); > ^~~~~~~~~~~~~~~~~~ > linux/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:588:9: note: treat > the string as an argument to avoid this > stats_dir_filename); > ^ > "%s", > linux/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:635:18: warning: > format string is not a string literal (potentially insecure) > [-Wformat-security] > p->kobj, counters_dir_filename); > ^~~~~~~~~~~~~~~~~~~~~ > linux/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:635:18: note: treat > the string as an argument to avoid this > p->kobj, counters_dir_filename); > ^ > "%s", > > Signed-off-by: Sunil Khatri <[email protected]> > CC: Philip Yang <[email protected]> > CC: Felix Kuehling <[email protected]>
There is a typo in the subject (amdkd instead of amdkfd), but apart from that: Reviewed-by: Christian König <[email protected]> > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c > b/drivers/gpu/drm/amd/amdkfd/kfd_process.c > index 0b3b0c26e05c..d202827df66e 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c > @@ -585,7 +585,7 @@ static void kfd_procfs_add_sysfs_stats(struct kfd_process > *p) > ret = kobject_init_and_add(pdd->kobj_stats, > &procfs_stats_type, > p->kobj, > - stats_dir_filename); > + "%s", stats_dir_filename); > > if (ret) { > pr_warn("Creating KFD proc/stats_%s folder failed", > @@ -632,7 +632,7 @@ static void kfd_procfs_add_sysfs_counters(struct > kfd_process *p) > return; > > ret = kobject_init_and_add(kobj_counters, &sysfs_counters_type, > - p->kobj, counters_dir_filename); > + p->kobj, "%s", > counters_dir_filename); > if (ret) { > pr_warn("Creating KFD proc/%s folder failed", > counters_dir_filename);
