On 13/10/17 09:22 PM, Harry Wentland wrote: > On 2017-10-12 08:22 PM, Dieter Nützel wrote: >> Hello, >> >> next (regression) compilation error: >> >> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In function >> ‘resource_map_pool_resources’: >> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: error: >> implicit declaration of function ‘acquire_first_split_pipe’; did you mean >> ‘acquire_first_free_pipe’? [-Werror=implicit-function-declaration] >> pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, stream); >> ^~~~~~~~~~~~~~~~~~~~~~~~ >> acquire_first_free_pipe >> >> >> It is wrongly (?) guarded behind: >> >> #if defined(CONFIG_DRM_AMD_DC_DCN1_0) >> static int acquire_first_split_pipe( >> struct resource_context *res_ctx, >> const struct resource_pool *pool, >> struct dc_stream_state *stream) >> [snip] >> > > Sent and merged a patch. This function only makes sense for DCN and shouldn't > be called otherwise. Thanks for reporting this. I gotta make sure to build > without the DCN flag in the future to avoid this.
Would it be possible to drop options like DRM_AMD_DC_FBC and DRM_AMD_DC_DCN1_0 from amd-staging-drm-next (but especially upstream), and just always compile the code? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
