On 12/16/25 11:21, Timur Kristóf wrote:
On 2025. december 16., kedd 9:27:34 középső államokbeli zónaidő Alex Deucher
wrote:
On Fri, Dec 5, 2025 at 9:49 PM Timur Kristóf <[email protected]>
wrote:
Fix a few issues with the initial DC analog connector
implementation that I've noticed since. I highly recommend
to backport this series to kernel versions that include
the DC analog series.
Did you have an update for this series, or are they ready to be applied?
Alex
Hi,
I re-reviewed my patches in this series again and I realized that my comment
was mistaken (I confused link encoder with stream encoder). So the patches
should be good as-is.
However, in the meantime Mauro got back to me this weekend, and told me that
he determined that the patch "Setup DAC encoder before using it" not only
doesn't fix it, but regresses the analog connector on his HD 7790 further.
Before this patch, he got a black screen on boot, but the DAC started working
after suspend/resume. After this patch, it no longer works for him even after
suspend/resume.
What do you think is the way to proceed?
A) Merge all patches but that one. I'll submit a corrected patch once we figure
out the HD 7790.
B) Merge the whole series as-is and I can submit a fix once we figured out what
is going on with the HD 7790.
Plan A sounds better. Let's not merge a patch with a known issue. I will
also share test results by the end of the week.
Thanks & best regards,
Timur
Timur Kristóf (5):
drm/amd/display: Pass proper DAC encoder ID to VBIOS
drm/amd/display: Correct color depth for SelectCRTC_Source
drm/amd/display: Add missing encoder setup to DACnEncoderControl
drm/amd/display: Setup DAC encoder before using it
drm/amd/display: Don't repeat DAC load detection
.../gpu/drm/amd/display/dc/bios/bios_parser.c | 4 +-
.../drm/amd/display/dc/bios/command_table.c | 44 +++++++++++++++----
.../drm/amd/display/dc/bios/command_table.h | 4 +-
.../drm/amd/display/dc/dce/dce_link_encoder.c | 2 +
.../amd/display/dc/dce/dce_stream_encoder.c | 25 ++++++++++-
.../amd/display/dc/hwss/dce110/dce110_hwseq.c | 28 +-----------
.../drm/amd/display/dc/inc/hw/link_encoder.h | 2 +
.../amd/display/dc/inc/hw/stream_encoder.h | 4 ++
.../amd/display/dc/link/hwss/link_hwss_dio.c | 4 ++
.../drm/amd/display/dc/link/link_detection.c | 7 ++-
.../drm/amd/display/dc/link/link_factory.c | 10 ++---
.../dc/resource/dce110/dce110_resource.c | 2 +
.../amd/display/include/bios_parser_types.h | 2 +-
13 files changed, 87 insertions(+), 51 deletions(-)
--
2.52.0
