[AMD Official Use Only - AMD Internal Distribution Only]
There is an existing bug->
if (type == SMU_TEMP_METRIC_BASEBOARD) {
/* Initialize base board temperature metrics */
data_table =
&smu->smu_table.tables[SMU_TABLE_BASEBOARD_TEMP_METRICS];
baseboard_temp_metrics =
(struct amdgpu_baseboard_temp_metrics_v1_0 *)
data_table->cache.buffer;
size = sizeof(*baseboard_temp_metrics);
} else {
data_table =
&smu->smu_table.tables[SMU_TABLE_GPUBOARD_TEMP_METRICS];
gpuboard_temp_metrics =
(struct amdgpu_gpuboard_temp_metrics_v1_0 *)
data_table->cache.buffer;
size = sizeof(*baseboard_temp_metrics); -> should be
gpuboard_temp_metrics
}
With above taken care
Series is
Reviewed-by: Asad Kamal <[email protected]>
Thanks & Regards
Asad
-----Original Message-----
From: Lazar, Lijo <[email protected]>
Sent: Monday, December 8, 2025 1:23 PM
To: [email protected]
Cc: Zhang, Hawking <[email protected]>; Deucher, Alexander
<[email protected]>; Kamal, Asad <[email protected]>
Subject: Re: [PATCH 0/7] Add cache interval to driver tables
<ping>
On 12/2/2025 5:09 PM, Lijo Lazar wrote:
> There are different metrics tables provided by driver, and they are all
> sourced from firmware.
> However, even with the same firmware table source, different classes
> of data could have different polling intervals. Hence driver shouldn't
> apply the same cache policy for all data coming from a single data
> source. This series adds driver tables with cache interval so that different
> tables could keep their own caching policy even if the data source is the
> same.
>
> Lijo Lazar (7):
> drm/amd/pm: Add smu driver table structure
> drm/amd/pm: Use driver table structure in smuv11
> drm/amd/pm: Use driver table structure in smuv12
> drm/amd/pm: Use driver table structure in smuv13
> drm/amd/pm: Use driver table structure in smuv14
> drm/amd/pm: Use cached gpu metrics table
> drm/amd/pm: Use driver table for board temperature
>
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 ++++--
> drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 105 ++++++++++++++++--
> .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 16 ++-
> .../amd/pm/swsmu/smu11/cyan_skillfish_ppt.c | 15 ++-
> .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 33 ++++--
> .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 16 ++-
> .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 3 +-
> .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 44 +++++---
> .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 14 ++-
> .../gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 +-
> .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 18 +--
> .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 +-
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 16 ++-
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c | 49 ++++----
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 17 +--
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 19 ++--
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 23 ++--
> .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 16 ++-
> .../drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 19 ++--
> .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 3 +-
> .../drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 19 ++--
> .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 16 ++-
> 22 files changed, 332 insertions(+), 166 deletions(-)
>
