On Tue, Dec 2, 2025 at 5:09 AM Srinivasan Shanmugam <[email protected]> wrote: > > The comment for sdma_v7_1_inst_gfx_resume() did not include the > inst_mask parameter, even though the function takes it as an argument. > > Update the comment to document inst_mask as the mask of SDMA engine > instances to be enabled. > > Fixes the below with gcc W=1: > drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c:644 function parameter 'inst_mask' not > described in 'sdma_v7_1_inst_gfx_resume' > > Cc: Likun Gao <[email protected]> > Cc: Le Ma <[email protected]> > Cc: Alex Deucher <[email protected]> > Cc: Christian König <[email protected]> > Signed-off-by: Srinivasan Shanmugam <[email protected]>
Reviewed-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c > b/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c > index 89ce07ae18b4..f998edf52c28 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c > @@ -635,7 +635,7 @@ static int sdma_v7_1_gfx_resume_instance(struct > amdgpu_device *adev, int i, bool > * sdma_v7_1_inst_gfx_resume - setup and start the async dma engines > * > * @adev: amdgpu_device pointer > - * inst_mask: mask of dma engine instances to be enabled > + * @inst_mask: mask of dma engine instances to be enabled > * > * Set up the gfx DMA ring buffers and enable them. > * Returns 0 for success, error for failure. > -- > 2.34.1 >
