Hello,
Today I tracked down 2 regressions with git bisect:
1. Crash: the most recent amd-drm-staging-next code based kernels
result in a complete crash on boot with no interaction possible. The
cause is a "tidy up" commit which actually inverts the logical
behavior. Went through the amd-gfx list to see this was already found.
If there is such a show-stopper regression which is simple to fix
please push the revert/fix to agd5f asap, to spare the Linux/AMD
enthusiasts running these kernels some pain.
2. Flicker issue: As wrote in my last mail the amd-staging-drm-next
causes heavy flickering horizontal lines. Had to do a large bisect to
find the bad commit. No idea what is precisely broken there but I hope
this helps to resolve it.
Many regards,
Martin
d5d178b20a4b4aa511ae050e10eb84ea6734bc3b is the first bad commit
commit d5d178b20a4b4aa511ae050e10eb84ea6734bc3b
Author: Rex Zhu <rex....@amd.com>
Date: Fri Sep 29 14:36:15 2017 +0800
drm/amd/powerplay: tidy up ret checks in amd_powerplay.c
Change-Id: Ibecbcebadb1cbe91e756ef469954da449feaa21a
Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>
Signed-off-by: Rex Zhu <rex....@amd.com>
:040000 040000 9f0b9c1ddad61406da496232ec04ff008fe673ef f7a35f31a191250c69c1c5b76f2a43746c114864 M drivers
--------------------
git bisect start
# good: [c854c55e8c0fa05b62aecdc2c86c876d14696f44] Fixed drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
git bisect good c854c55e8c0fa05b62aecdc2c86c876d14696f44
# bad: [eba2d57add96e1052cdb3f6f924a7041405cf26e] Merge branch 'amd-staging-drm-next' of git://people.freedesktop.org/~agd5f/linux into mbab_4.13_ubuntu
git bisect bad eba2d57add96e1052cdb3f6f924a7041405cf26e
# skip: [98c186515965c561600bf4fa325da56e2573870c] amdgpu/nbio: use constant nbio_hdp_flush_reg structs.
git bisect skip 98c186515965c561600bf4fa325da56e2573870c
# skip: [166fccc38ae9aef83f673426c06f8bd0e0bb63c5] amdgpu/pp: rewrite polaris pwrvirus upload code.
git bisect skip 166fccc38ae9aef83f673426c06f8bd0e0bb63c5
# good: [6fc753d0a1cc9f3b774aef070e35265fb257ebc1] scsi: megaraid_sas: Return pended IOCTLs with cmd_status MFI_STAT_WRONG_STATE in case adapter is dead
git bisect good 6fc753d0a1cc9f3b774aef070e35265fb257ebc1
# good: [0fe655e3139999b8b00d85c7ccea8cc3254d901f] drm/amd/powerplay: export new interfaces in amd_pm_funcs
git bisect good 0fe655e3139999b8b00d85c7ccea8cc3254d901f
# good: [0fe655e3139999b8b00d85c7ccea8cc3254d901f] drm/amd/powerplay: export new interfaces in amd_pm_funcs
git bisect good 0fe655e3139999b8b00d85c7ccea8cc3254d901f
# good: [6eb9c0fc1bca163dd084da77d77bb11c4b1639bc] Linux 4.13.4
git bisect good 6eb9c0fc1bca163dd084da77d77bb11c4b1639bc
# good: [50a15beab73d7b7b7fd1e16048da9a0cef7afb67] Merge branch 'amd-staging-drm-next' of git://people.freedesktop.org/~agd5f/linux into mbab_4.13_ubuntu
git bisect good 50a15beab73d7b7b7fd1e16048da9a0cef7afb67
# bad: [1a7d8841d41415927887b98f16c10442ba24f4b2] amdgfx/gfx: don't use static objects for ce/de meta. (v2)
git bisect bad 1a7d8841d41415927887b98f16c10442ba24f4b2
# bad: [344dda82b64781b889983836fbe10a4b9ce49a66] drm/amdgpu: move DC and PP shared data structures to dm_pp_interface.h
git bisect bad 344dda82b64781b889983836fbe10a4b9ce49a66
# good: [6a1f70848ca224e9fa74dfc72c05a0f9c8711b98] drm/amd/powerplay: refine code in amd_powerplay.c
git bisect good 6a1f70848ca224e9fa74dfc72c05a0f9c8711b98
# bad: [d5d178b20a4b4aa511ae050e10eb84ea6734bc3b] drm/amd/powerplay: tidy up ret checks in amd_powerplay.c
git bisect bad d5d178b20a4b4aa511ae050e10eb84ea6734bc3b
# first bad commit: [d5d178b20a4b4aa511ae050e10eb84ea6734bc3b] drm/amd/powerplay: tidy up ret checks in amd_powerplay.c0b6b4cbf77c995a34a4ec3d705a636434dadc51a is the first bad commit
commit 0b6b4cbf77c995a34a4ec3d705a636434dadc51a
Author: Rex Zhu <rex....@amd.com>
Date: Thu Sep 14 21:05:18 2017 +0800
drm/amd/powerplay: Add support for CI asics to hwmgr
Add support for CI asics (Bonaire, Hawaii) to
the powerplay hwmgr
Change-Id: Ia0a31f631dfd717807c16c6c166c994566f644c9
Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>
Signed-off-by: Rex Zhu <rex....@amd.com>
:040000 040000 b2a034b2e3c56cef96f3f12c2b583b3da5b8caba 77fb81ef872079201db9169f2d625aedc9cea101 M drivers
--------------------
git bisect start
# good: [6eb9c0fc1bca163dd084da77d77bb11c4b1639bc] Linux 4.13.4
git bisect good 6eb9c0fc1bca163dd084da77d77bb11c4b1639bc
# bad: [50a15beab73d7b7b7fd1e16048da9a0cef7afb67] Merge branch 'amd-staging-drm-next' of git://people.freedesktop.org/~agd5f/linux into mbab_4.13_ubuntu
git bisect bad 50a15beab73d7b7b7fd1e16048da9a0cef7afb67
# skip: [614d806e08921e77a75b7026388d35be5f451b50] drm/amd/display: remove HDMI deep color debug flag
git bisect skip 614d806e08921e77a75b7026388d35be5f451b50
# skip: [9b17970bec7d5a759ca753b68b1e83d96305b62e] drm/amd/display: Temporary disable PSR for HBR2 & HBR3
git bisect skip 9b17970bec7d5a759ca753b68b1e83d96305b62e
# skip: [9b17970bec7d5a759ca753b68b1e83d96305b62e] drm/amd/display: Temporary disable PSR for HBR2 & HBR3
git bisect skip 9b17970bec7d5a759ca753b68b1e83d96305b62e
# good: [a8da3223f75c4be676273ed22ca6725d632bf32a] iio: adc: ti-ads1015: fix incorrect data rate setting update
git bisect good a8da3223f75c4be676273ed22ca6725d632bf32a
# good: [4ef72453311a697b3fb90da9c86c83012911ccf9] drm/amdgpu: added api for stopping psp ring (v2)
git bisect good 4ef72453311a697b3fb90da9c86c83012911ccf9
# good: [4ef72453311a697b3fb90da9c86c83012911ccf9] drm/amdgpu: added api for stopping psp ring (v2)
git bisect good 4ef72453311a697b3fb90da9c86c83012911ccf9
# skip: [1dafcc0f530c410b06adfdcfc2097108e59c9d45] drm/amd/display: Enabling VSR on 4K display causes black screen
git bisect skip 1dafcc0f530c410b06adfdcfc2097108e59c9d45
# skip: [97117dabda8be0b1bd38c5104796f608ceb49a7c] drm/amd/display: enable clock gating and dchubp power gating
git bisect skip 97117dabda8be0b1bd38c5104796f608ceb49a7c
# skip: [9d1371711b61bb3996a56abced903a4b8227bd34] drm/amd/display: fix mpo + split pipe aquisition failure
git bisect skip 9d1371711b61bb3996a56abced903a4b8227bd34
# skip: [5abd8c8d5f0164f06adcf8f9484567ee6e9816f5] drm/amd/display: Fixed 4K black issue by refactor update surface.
git bisect skip 5abd8c8d5f0164f06adcf8f9484567ee6e9816f5
# skip: [d472526a813b7fca09d2bf64c1cbc0dfa2bd8d78] drm/amd/display: remove disable_clk_gate debug flag for DCN
git bisect skip d472526a813b7fca09d2bf64c1cbc0dfa2bd8d78
# skip: [975f652a7bd31f7beada49a41f18bdfc6f1579f4] drm/amd: Avoid using x86-specific _BITOPS_LONG_SHIFT
git bisect skip 975f652a7bd31f7beada49a41f18bdfc6f1579f4
# skip: [655804a1adeeee9f9c28dbb0b4e8802bdfdc018b] drm/amd/display: fix enable_optc_clock reg_wait timeouts
git bisect skip 655804a1adeeee9f9c28dbb0b4e8802bdfdc018b
# skip: [be697b3d14d28c303e9a63e5edd893539cea6430] drm/amd/display: Remove LINUX_VERSION_CODE check
git bisect skip be697b3d14d28c303e9a63e5edd893539cea6430
# skip: [d9d9dc5c44f113bd256551ce2cd17a6d0fe06360] drm/amd/display: DAL3 RV get DPREFCLK SpreadspectrumInfo from smu_info
git bisect skip d9d9dc5c44f113bd256551ce2cd17a6d0fe06360
# skip: [78b3fb9c5d9e0e06eca9516791a9cc567b24c1ef] drm/amd/powerplay: Simplify smu7_voting_clients()
git bisect skip 78b3fb9c5d9e0e06eca9516791a9cc567b24c1ef
# skip: [8903422b9dabdad726321c7c2b15afd20981c551] drm/amd/display: Leave all validate_ctx life cycle management to DC.
git bisect skip 8903422b9dabdad726321c7c2b15afd20981c551
# skip: [75f3d0d70cf3f039cda9ed00fa3b9123e280f41b] drm/amd/display: Format changes to bring in line with internal tree
git bisect skip 75f3d0d70cf3f039cda9ed00fa3b9123e280f41b
# skip: [2679e902b88ab3da1dd9afe381591d24b049bb1e] drm/amd/display: Refine globallock.
git bisect skip 2679e902b88ab3da1dd9afe381591d24b049bb1e
# good: [5ba0dbb809f4ad3f2e36f2eaf3761fc735fb19bd] drm/amd/display: USB-C to HDMI dongle not light
git bisect good 5ba0dbb809f4ad3f2e36f2eaf3761fc735fb19bd
# good: [c84aac195f8d61431df93eedfafa201a88b9e08e] UBUNTU: SAUCE: ahci: thunderx2: Fix for errata that affects stop engine
git bisect good c84aac195f8d61431df93eedfafa201a88b9e08e
# bad: [a47d2739ec78be3e213fc64a9831be7974f3e330] drm/amd/powerplay: refine phm_register_thermal_interrupt interface
git bisect bad a47d2739ec78be3e213fc64a9831be7974f3e330
# bad: [68d3290d9a3be4a2f8d3b54b74acf39ecb53d79e] drm/amdkfd: Separate doorbell allocation from PASID
git bisect bad 68d3290d9a3be4a2f8d3b54b74acf39ecb53d79e
# good: [43dd6fde5df450938568885249b836eb376e2ad6] drm/amd/display: Update include to bring in line with internal tree
git bisect good 43dd6fde5df450938568885249b836eb376e2ad6
# good: [01a719a324ae52ac019ce4e290cc4265e5cb021f] drm/amd/powerplay: fix pcie max lane define error
git bisect good 01a719a324ae52ac019ce4e290cc4265e5cb021f
# bad: [0b6b4cbf77c995a34a4ec3d705a636434dadc51a] drm/amd/powerplay: Add support for CI asics to hwmgr
git bisect bad 0b6b4cbf77c995a34a4ec3d705a636434dadc51a
# good: [c18b037efbbdaf73a6d924f20996f121938a16ec] drm/amd/powerplay: refine dmesg info under powerplay
git bisect good c18b037efbbdaf73a6d924f20996f121938a16ec
# good: [e83924ab5084248938b5f9513d2e636668dde98b] drm/amd/powerplay: Add support functions for CI to ppatomctrl.c
git bisect good e83924ab5084248938b5f9513d2e636668dde98b
# first bad commit: [0b6b4cbf77c995a34a4ec3d705a636434dadc51a] drm/amd/powerplay: Add support for CI asics to hwmgr_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
