On 11/5/25 13:14, Prike Liang wrote:
> Ensure the userq TLB flush is emitted only after
> the VM update finishes and the PT BOs have been
> annotated with bookkeeping fences.
>
> Suggested-by: Christian König <[email protected]>
> Signed-off-by: Prike Liang <[email protected]>
Reviewed-by: Christian König <[email protected]>
Could be that people start to complain that this results in extra overhead, but
that shouldn't be much of an issue.
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index db66b4232de0..79d687dee877 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1062,7 +1062,7 @@ amdgpu_vm_tlb_flush(struct amdgpu_vm_update_params
> *params,
> }
>
> /* Prepare a TLB flush fence to be attached to PTs */
> - if (!params->unlocked && vm->is_compute_context) {
> + if (!params->unlocked) {
> amdgpu_vm_tlb_fence_create(params->adev, vm, fence);
>
> /* Makes sure no PD/PT is freed before the flush */
