On Mon, Aug 25, 2025 at 10:33 AM Eric Huang <[email protected]> wrote:
>
> When creating p2p links, KFD needs to check XGMI link
> with two conditions, hive_id and is_sharing_enabled,
> but it is missing to check is_sharing_enabled, so add
> it to fix the error.
>
> Signed-off-by: Eric Huang <[email protected]>

Acked-by: Alex Deucher <[email protected]>

> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c 
> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 82dbd68d8c99..5c98746eb72d 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -1589,7 +1589,8 @@ static int kfd_dev_create_p2p_links(void)
>                         break;
>                 if (!dev->gpu || !dev->gpu->adev ||
>                     (dev->gpu->kfd->hive_id &&
> -                    dev->gpu->kfd->hive_id == new_dev->gpu->kfd->hive_id))
> +                    dev->gpu->kfd->hive_id == new_dev->gpu->kfd->hive_id &&
> +                    amdgpu_xgmi_get_is_sharing_enabled(dev->gpu->adev, 
> new_dev->gpu->adev)))
>                         goto next;
>
>                 /* check if node(s) is/are peer accessible in one direction 
> or bi-direction */
> --
> 2.34.1
>

Reply via email to