On Fri, Jun 13, 2025 at 12:06 PM Lazar, Lijo <lijo.la...@amd.com> wrote:
>
>
>
> On 6/13/2025 9:31 PM, Alex Deucher wrote:
> > On Fri, Jun 13, 2025 at 10:42 AM Kenneth Feng <kenneth.f...@amd.com> wrote:
> >>
> >> move the dpm table setting back after featureenablemend due to dependancy.
> >
> > What is the dependency? Can you provide more details?
> >
>
> For SMUv13.0.6, there is no pptable. We get all the frequency tables
> from FW during this callback. Those frequency tables are available
> through FW metrics and it needs DPM to be enabled.
Thanks. Please add that to the commit message. With that, the patch is:
Acked-by: Alex Deucher <alexander.deuc...@amd.com>
>
> Thanks,
> Lijo
>
> > Alex
> >
> >>
> >> Signed-off-by: Kenneth Feng <kenneth.f...@amd.com>
> >> ---
> >> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 22 +++++++++++-----------
> >> 1 file changed, 11 insertions(+), 11 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> >> b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> >> index 824fcc6dd32a..cf4ac3914b68 100644
> >> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> >> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> >> @@ -1687,17 +1687,6 @@ static int smu_smc_hw_setup(struct smu_context *smu)
> >> }
> >> }
> >>
> >> - /*
> >> - * Set initialized values (get from vbios) to dpm tables context
> >> such as
> >> - * gfxclk, memclk, dcefclk, and etc. And enable the DPM feature
> >> for each
> >> - * type of clks.
> >> - */
> >> - ret = smu_set_default_dpm_table(smu);
> >> - if (ret) {
> >> - dev_err(adev->dev, "Failed to setup default dpm clock
> >> tables!\n");
> >> - return ret;
> >> - }
> >> -
> >> if (adev->pm.pcie_gen_mask & CAIL_PCIE_LINK_SPEED_SUPPORT_GEN5)
> >> pcie_gen = 4;
> >> else if (adev->pm.pcie_gen_mask &
> >> CAIL_PCIE_LINK_SPEED_SUPPORT_GEN4)
> >> @@ -1739,6 +1728,17 @@ static int smu_smc_hw_setup(struct smu_context *smu)
> >> return ret;
> >> }
> >>
> >> + /*
> >> + * Set initialized values (get from vbios) to dpm tables context
> >> such as
> >> + * gfxclk, memclk, dcefclk, and etc. And enable the DPM feature
> >> for each
> >> + * type of clks.
> >> + */
> >> + ret = smu_set_default_dpm_table(smu);
> >> + if (ret) {
> >> + dev_err(adev->dev, "Failed to setup default dpm clock
> >> tables!\n");
> >> + return ret;
> >> + }
> >> +
> >> smu_init_xgmi_plpd_mode(smu);
> >>
> >> ret = smu_feature_get_enabled_mask(smu, &features_supported);
> >> --
> >> 2.34.1
> >>
>
