On 5/27/25 10:58, Sunil Khatri wrote:
> This reverts commit 714bbbf20a7266e48632fab466563e695af9acb5.
> bisected to this change which is causing the flikering issue in the UI
> for various apps like glxgears and unigen heaven.
Is that flickering also there when using kernel queues?
If not then without an explanation where that flickering is coming from for
user queues I have to reject that.
It seems to be the right thing TODO and we are still in the process of
hammering out all the bugs for user queues.
Regards,
Christian.
> Also when we set user_queue=1, which enable both user and kernel submissions
> the userqueue tests in IGT also fail.
>
> Signed-off-by: Sunil Khatri <sunil.kha...@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> index d6ae9974c952..5576ed0b508f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> @@ -249,8 +249,9 @@ int amdgpu_sync_resv(struct amdgpu_device *adev, struct
> amdgpu_sync *sync,
>
> if (resv == NULL)
> return -EINVAL;
> - /* Implicitly sync only to KERNEL, WRITE and READ */
> - dma_resv_for_each_fence(&cursor, resv, DMA_RESV_USAGE_READ, f) {
> +
> + /* TODO: Use DMA_RESV_USAGE_READ here */
> + dma_resv_for_each_fence(&cursor, resv, DMA_RESV_USAGE_BOOKKEEP, f) {
> dma_fence_chain_for_each(f, f) {
> struct dma_fence *tmp = dma_fence_chain_contained(f);
>
