[Public]
[Public]
With the change suggested by Harish below this patch looks good to me too.
Reviewed-by: Alexandru Tudor <alexandru.tu...@amd.com>
________________________________
From: Kasiviswanathan, Harish <harish.kasiviswanat...@amd.com>
Sent: Monday, May 26, 2025 1:48 PM
To: Clement, Sunday <sunday.clem...@amd.com>; amd-gfx@lists.freedesktop.org
<amd-gfx@lists.freedesktop.org>
Cc: Tudor, Alexandru <alexandru.tu...@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Identical code for different branches
[Public]
You can remove BUG:SWDEV-534537 from commit message as it doesn’t provide any
information to public. With that this patch is
Reviewed-by: Harish Kasiviswanathan <harish.kasiviswanat...@amd.com.
-----Original Message-----
From: Clement, Sunday <sunday.clem...@amd.com>
Sent: Friday, May 23, 2025 7:54 PM
To: amd-gfx@lists.freedesktop.org
Cc: Tudor, Alexandru <alexandru.tu...@amd.com>; Kasiviswanathan, Harish
<harish.kasiviswanat...@amd.com>; Clement, Sunday <sunday.clem...@amd.com>
Subject: [PATCH] drm/amdkfd: Identical code for different branches
This patch removes the if/else statement in the
cik_event_interrupt_wq function because it is redundant
with both branches resulting in identical outcomes,
this improves code readibility.
BUG:SWDEV-534537
Signed-off-by: Sunday Clement <sunday.clem...@amd.com>
---
drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
index 981d9adcc5e1..25f32771b228 100644
--- a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
+++ b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
@@ -125,11 +125,7 @@ static void cik_event_interrupt_wq(struct kfd_node *dev,
return;
}
- if (info.vmid == vmid)
- kfd_signal_vm_fault_event(pdd, &info, NULL);
- else
- kfd_signal_vm_fault_event(pdd, &info, NULL);
-
+ kfd_signal_vm_fault_event(pdd, &info, NULL);
kfd_unref_process(p);
}
}
--
2.43.0
