[AMD Official Use Only - AMD Internal Distribution Only]
Ping ..
Regards,
Prike
> -----Original Message-----
> From: Liang, Prike <prike.li...@amd.com>
> Sent: Friday, March 28, 2025 7:52 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Liang, Prike
> <prike.li...@amd.com>
> Subject: [PATCH] drm/amdgpu: remove the duplicated mes queue active state
> setting
>
> The MES queue deactivation and active status are already set in
> mes_userq_unmap|map(), so the caller needn't set the queue_active bit again.
>
> Signed-off-by: Prike Liang <prike.li...@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/mes_userqueue.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> index b469b800119f..b9705cbec74d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> @@ -358,10 +358,8 @@ mes_userq_mqd_destroy(struct amdgpu_userq_mgr
> *uq_mgr, static int mes_userq_suspend(struct amdgpu_userq_mgr *uq_mgr,
> struct amdgpu_usermode_queue *queue) {
> - if (queue->queue_active) {
> + if (queue->queue_active)
> mes_userq_unmap(uq_mgr, queue);
> - queue->queue_active = false;
> - }
>
> return 0;
> }
> @@ -379,8 +377,6 @@ static int mes_userq_resume(struct amdgpu_userq_mgr
> *uq_mgr,
> DRM_ERROR("Failed to resume queue\n");
> return ret;
> }
> -
> - queue->queue_active = true;
> return 0;
> }
>
> --
> 2.34.1
