Re: [PATCH v1 1/1] drm/amdgpu: fix a smatch static checker warning in amdgpu_pci_slot_reset

[Sun, Ce(Overlord)]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Lijo,
      There is indeed a single device issue, thank you very much






Thanks,
Sun,Ce

________________________________
From: Lazar, Lijo <lijo.la...@amd.com>
Sent: Thursday, April 10, 2025 4:11 PM
To: Sun, Ce(Overlord) <ce....@amd.com>; amd-gfx@lists.freedesktop.org 
<amd-gfx@lists.freedesktop.org>
Cc: dan.carpen...@linaro.org <dan.carpen...@linaro.org>
Subject: Re: [PATCH v1 1/1] drm/amdgpu: fix a smatch static checker warning in 
amdgpu_pci_slot_reset



On 4/9/2025 5:40 PM, Ce Sun wrote:
> Fixes smatch warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset()
> warn: iterator used outside loop: 'tmp_adev'
>
> Fixes: 8ba904f54148 ("drm/amdgpu: Multi-GPU DPC recovery support")
>
> Signed-off-by: Ce Sun <cesun...@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 60269fba5745..eb0589a09a27 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -6846,7 +6846,7 @@ pci_ers_result_t amdgpu_pci_slot_reset(struct pci_dev 
> *pdev)
>                dev_info(adev->dev, "PCIe error recovery succeeded\n");
>        } else {
>                dev_err(adev->dev, "PCIe error recovery failed, err:%d\n", r);
> -             if (tmp_adev) {
> +             if (hive) {

Hi Ce Sun,

Looks like your original patch broke single device handling path. That
one will need a revisit.

Thanks,
Lijo

>                        list_for_each_entry(tmp_adev, &device_list, reset_list)
>                                amdgpu_device_unset_mp1_state(tmp_adev);
>                        amdgpu_device_unlock_reset_domain(adev->reset_domain);