[AMD Official Use Only - AMD Internal Distribution Only]
Sounds good. Series is reviewed then.
Reviewed-by: Sunil Khatri <sunil.kha...@amd.com>
Regards
Sunil khatri
-----Original Message-----
From: Alex Deucher <alexdeuc...@gmail.com>
Sent: Wednesday, March 26, 2025 9:23 PM
To: Khatri, Sunil <sunil.kha...@amd.com>
Cc: Deucher, Alexander <alexander.deuc...@amd.com>;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/amdgpu/gfx11: fix num_mec
On Wed, Mar 26, 2025 at 11:48 AM Khatri, Sunil <sunil.kha...@amd.com> wrote:
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Gfx11 now we have same values, hence we don't need to differentiate between
> two sets , only one set is needed like below.
For these fixes, I'd like to keep this as is so we can get these patches to
stable and then clean this up as a follow up patch.
Alex
>
> As below
> case IP_VERSION(11, 0, 0):
> case IP_VERSION(11, 0, 2):
> case IP_VERSION(11, 0, 3):
> case IP_VERSION(11, 0, 1):
> case IP_VERSION(11, 0, 4):
> case IP_VERSION(11, 5, 0):
> case IP_VERSION(11, 5, 1):
> case IP_VERSION(11, 5, 2):
> case IP_VERSION(11, 5, 3):
> adev->gfx.me.num_me = 1;
> adev->gfx.me.num_pipe_per_me = 1;
> adev->gfx.me.num_queue_per_pipe = 1;
> adev->gfx.mec.num_mec = 1;
> adev->gfx.mec.num_pipe_per_mec = 4;
> adev->gfx.mec.num_queue_per_pipe = 4; #ifdef
> CONFIG_DRM_AMDGPU_NAVI3X_USERQ
> adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;
> adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] =
> &userq_mes_funcs; #endif
> break;
>
> Regards
> Sunil Khatri
>
> -----Original Message-----
> From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of
> Alex Deucher
> Sent: Wednesday, March 26, 2025 7:13 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <alexander.deuc...@amd.com>
> Subject: [PATCH 1/2] drm/amdgpu/gfx11: fix num_mec
>
> GC11 only has 1 mec.
>
> Fixes: 3d879e81f0f9 ("drm/amdgpu: add init support for GFX11 (v2)")
> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index e0a9b10d645c6..a9ef33205c541 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -1573,7 +1573,7 @@ static int gfx_v11_0_sw_init(struct amdgpu_ip_block
> *ip_block)
> adev->gfx.me.num_me = 1;
> adev->gfx.me.num_pipe_per_me = 1;
> adev->gfx.me.num_queue_per_pipe = 1;
> - adev->gfx.mec.num_mec = 2;
> + adev->gfx.mec.num_mec = 1;
> adev->gfx.mec.num_pipe_per_mec = 4;
> adev->gfx.mec.num_queue_per_pipe = 4; #ifdef
> CONFIG_DRM_AMDGPU_NAVI3X_USERQ
> --
> 2.49.0
>
