On 2/27/2025 9:12 PM, Christian König wrote:
No, no that's wrong.

That timeline_syncobj is NULL is not an error. In other words when 
args->vm_timeline_syncobj_out == 0 then amdgpu_gem_update_timeline_node() 
should just set timeline_syncobj=NULL and return 0.

The error happens only if either args->vm_timeline_syncobj_out has a handler we 
can't find or if we fail to allocate memory for the timeline_chain.

In this case the return value should be EINVAl or ENOMEM and then we absolutely 
should abort the operation.
Noted.
Thank you,
Arvind

Reply via email to