From: Tom Chung <chiahsuan.ch...@amd.com>

[Why]
The enum DC_PSR_VERSION_SU_1 of psr_version is 1 and
DC_PSR_VERSION_UNSUPPORTED is 0xFFFFFFFF.

The original code may has chance trigger the amdgpu_dm_psr_enable()
while psr version is set to DC_PSR_VERSION_UNSUPPORTED.

[How]
Modify the condition to psr->psr_version == DC_PSR_VERSION_SU_1

Reviewed-by: Sun peng Li <sunpeng...@amd.com>
Signed-off-by: Tom Chung <chiahsuan.ch...@amd.com>
Signed-off-by: Roman Li <roman...@amd.com>
Tested-by: Daniel Wheeler <daniel.whee...@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index a5fbbee955a2..a579c11b4324 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -8962,7 +8962,7 @@ static void amdgpu_dm_enable_self_refresh(struct 
amdgpu_crtc *acrtc_attach,
                    (current_ts - psr->psr_dirty_rects_change_timestamp_ns) > 
500000000) {
                        if (pr->replay_feature_enabled && 
!pr->replay_allow_active)
                                amdgpu_dm_replay_enable(acrtc_state->stream, 
true);
-                       if (psr->psr_version >= DC_PSR_VERSION_SU_1 &&
+                       if (psr->psr_version == DC_PSR_VERSION_SU_1 &&
                            !psr->psr_allow_active && 
!aconn->disallow_edp_enter_psr)
                                amdgpu_dm_psr_enable(acrtc_state->stream);
                }
-- 
2.34.1

Reply via email to