Re: [PATCH v2 07/08] drm/amdgpu: Add the missing error handling for xa_store() call

[Christian König]

Am 25.09.24 um 21:59 schrieb Arunpravin Paneer Selvam:

Add the missing error handling for xa_store() call in the function
amdgpu_userq_fence_driver_alloc().

Signed-off-by: Arunpravin Paneer Selvam <arunpravin.paneersel...@amd.com>

Reviewed-by: Christian König <christian.koe...@amd.com>

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index f3576c31428c..43429661f62d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
@@ -101,9 +101,11 @@ int amdgpu_userq_fence_driver_alloc(struct amdgpu_device 
*adev,
        get_task_comm(fence_drv->timeline_name, current);

xa_lock_irqsave(&adev->userq_xa, flags);

-       __xa_store(&adev->userq_xa, userq->doorbell_index,
-                  fence_drv, GFP_KERNEL);
+       r = xa_err(__xa_store(&adev->userq_xa, userq->doorbell_index,
+                             fence_drv, GFP_KERNEL));
        xa_unlock_irqrestore(&adev->userq_xa, flags);
+       if (r)
+               goto free_seq64;

userq->fence_drv = fence_drv;