Le 19/08/24 - 16:57, Harry Wentland a écrit :
> Not all HW will be able to do bypass on all color
> operations. Introduce an 'allow_bypass' boolean for
> all colorop init functions and only create the BYPASS
> property when it's true.

You did not change the documentation of struct drm_colorop_state, so can 
we expect state->bypass to be always valid (ie. false when bypass is not 
possible)?

I don't think so, because drm_atomic_helper_colorop_duplicate_state 
/ drm_colorop_reset are setting the bypass to true. Maybe you can add 
something like this?

        /**
         * @bypass:
         *
         * When the property BYPASS exists on this colorop, this stores 
         * the requested bypass state: true if colorop shall be bypassed, 
         * false if colorop is enabled.
         */
 
[...]

Reply via email to