[WHAT & HOW]
advanced_pstate_switching was initialized to false and never assigned to
another value; as a result !advanced_pstate_switching is always true and
should be removed.

This fixes 2 DEADCODE issues reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.sique...@amd.com>
Acked-by: Alex Hung <alex.h...@amd.com>
Signed-off-by: Alex Hung <alex.h...@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c 
b/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c
index 90bb6e718301..60e2bf4ae6de 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c
@@ -442,7 +442,6 @@ static bool optimize_pstate_with_svp_and_drr(struct 
dml2_context *dml2, struct d
        bool result = false;
        int drr_display_index = 0, non_svp_streams = 0;
        bool force_svp = dml2->config.svp_pstate.force_enable_subvp;
-       bool advanced_pstate_switching = false;
 
        display_state->bw_ctx.bw.dcn.clk.fw_based_mclk_switching = false;
        display_state->bw_ctx.bw.dcn.legacy_svp_drr_stream_index_valid = false;
@@ -451,8 +450,7 @@ static bool optimize_pstate_with_svp_and_drr(struct 
dml2_context *dml2, struct d
 
        if (!result) {
                pstate_optimization_done = true;
-       } else if (!advanced_pstate_switching ||
-               (s->mode_support_info.DRAMClockChangeSupport[0] != 
dml_dram_clock_change_unsupported && !force_svp)) {
+       } else if (s->mode_support_info.DRAMClockChangeSupport[0] != 
dml_dram_clock_change_unsupported && !force_svp) {
                pstate_optimization_success = true;
                pstate_optimization_done = true;
        }
-- 
2.34.1

Reply via email to