[AMD Official Use Only - General]

Reviewed-by: Harish Kasiviswanathan <harish.kasiviswanat...@amd.com>


-----Original Message-----
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Mukul Joshi
Sent: Thursday, May 9, 2024 6:05 PM
To: amd-gfx@lists.freedesktop.org
Cc: Kuehling, Felix <felix.kuehl...@amd.com>; Joshi, Mukul <mukul.jo...@amd.com>
Subject: [PATCH] drm/amdkfd: Fix CU Masking for GFX 9.4.3

We are incorrectly passing the first XCC's MQD when
updating CU masks for other XCCs in the partition. Fix
this by passing the MQD for the XCC currently being
updated with CU mask to update_cu_mask function.

Fixes: fc6efed2c728 ("drm/amdkfd: Update CU masking for GFX 9.4.3")
Signed-off-by: Mukul Joshi <mukul.jo...@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
index 542191656aeb..399fa2106631 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
@@ -715,7 +715,7 @@ static void update_mqd_v9_4_3(struct mqd_manager *mm, void 
*mqd,
                m = get_mqd(mqd + size * xcc);
                update_mqd(mm, m, q, minfo);

-               update_cu_mask(mm, mqd, minfo, xcc);
+               update_cu_mask(mm, m, minfo, xcc);

                if (q->format == KFD_QUEUE_FORMAT_AQL) {
                        switch (xcc) {
--
2.35.1

Reply via email to