RE: [PATCH 3/4] drm/amdgpu: Using uninitialized value new_state.jpeg when calling adev->vcn.pause_dpg_mode

[Zhang, Jesse(Jie)]

[AMD Official Use Only - General]

Please ignore this patch:

For vcn_v1, it override the idle work handler and initialize new_state.jpeg   
at the function vcn_v1_0_idle_work_handler.

/* Override the work func */
 adev->vcn.idle_work.work.func = vcn_v1_0_idle_work_handler;

-----Original Message-----
From: jesse.zh...@amd.com <jesse.zh...@amd.com>
Sent: Wednesday, April 24, 2024 10:50 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian 
<christian.koe...@amd.com>; Huang, Tim <tim.hu...@amd.com>; Zhang, Jesse(Jie) 
<jesse.zh...@amd.com>; Zhang, Jesse(Jie) <jesse.zh...@amd.com>
Subject: [PATCH 3/4] drm/amdgpu: Using uninitialized value new_state.jpeg when 
calling adev->vcn.pause_dpg_mode

From: Jesse Zhang <jesse.zh...@amd.com>

Initialize the new_state.jpeg before it used

Signed-off-by: Jesse Zhang <jesse.zh...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
index 677eb141554e..13125ddd5e86 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
@@ -410,6 +410,11 @@ static void amdgpu_vcn_idle_work_handler(struct 
work_struct *work)
                        else
                                new_state.fw_based = VCN_DPG_STATE__UNPAUSE;

+                       if 
(amdgpu_fence_count_emitted(adev->jpeg.inst->ring_dec))
+                               new_state.jpeg = VCN_DPG_STATE__PAUSE;
+                       else
+                               new_state.jpeg = VCN_DPG_STATE__UNPAUSE;
+
                        adev->vcn.pause_dpg_mode(adev, j, &new_state);
                }

--
2.25.1