On 4/17/2024 11:23 AM, Ma Jun wrote:
> gpu_od should be removed if it's an empty directory
>
> Signed-off-by: Ma Jun <jun....@amd.com>
> Reported-by: Yang Wang <kevinyang.w...@amd.com>
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index a20e03e69d38..0c13e5520e77 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -4338,6 +4338,13 @@ static int amdgpu_od_set_init(struct amdgpu_device
> *adev)
> }
> }
>
> + /*
> + * If gpu_od is the first member in the list, that means gpu_od is an
> + * empty directory, so remove it.
> + */
> + if (list_is_first(&top_set->entry, &adev->pm.od_kobj_list))
Instead of assuming any order, what about using "list_is_singular" - if
this is the only entry in the list?
Thanks,
Lijo
> + goto err_out;
> +
> return 0;
>
> err_out:
