Re: [PATCH] drm/amdgpu: validate the parameters of amdgpu_vm_bo_clear_mappings

[Christian König]

Am 11.04.24 um 05:28 schrieb xinhui pan:

Ensure there is no address overlapping.

Reported-by: Vlad Stolyarov <he...@google.com>
Signed-off-by: xinhui pan <xinhui....@amd.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 8af3f0fd3073..f1315a854192 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1852,6 +1852,12 @@ int amdgpu_vm_bo_clear_mappings(struct amdgpu_device 
*adev,
        LIST_HEAD(removed);
        uint64_t eaddr;

+ /* validate the parameters */

+       if (saddr & ~PAGE_MASK || size & ~PAGE_MASK)
+               return -EINVAL;
+       if (saddr + size <= saddr)
+               return -EINVAL;
+

Why the heck should we do that? Looks invalid to me.

Regards,
Christian.

        eaddr = saddr + size - 1;
        saddr /= AMDGPU_GPU_PAGE_SIZE;
        eaddr /= AMDGPU_GPU_PAGE_SIZE;