Hi Mario,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on drm-intel/for-linux-next-fixes drm-xe/drm-xe-next 
linus/master v6.8-rc2 next-20240202]
[cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next 
rafael-pm/acpi-bus rafael-pm/devprop]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-video-Handle-fetching-EDID-that-is-longer-than-256-bytes/20240202-061301
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git 
linux-next
patch link:    
https://lore.kernel.org/r/20240201221119.42564-4-mario.limonciello%40amd.com
patch subject: [PATCH v3 3/5] drm/amd: Fetch the EDID from _DDC if available 
for eDP
config: i386-randconfig-004-20240203 
(https://download.01.org/0day-ci/archive/20240203/202402032030.ibef5cme-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20240203/202402032030.ibef5cme-...@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <l...@intel.com>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202402032030.ibef5cme-...@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 
'create_eml_sink':
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6599:5: warning: 
>> 'edid' is used uninitialized in this function [-Wuninitialized]
    6599 |  if (!edid)
         |     ^


vim +/edid +6599 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c

  6582  
  6583  static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
  6584  {
  6585          struct drm_connector *connector = &aconnector->base;
  6586          struct amdgpu_connector *amdgpu_connector = 
to_amdgpu_connector(&aconnector->base);
  6587          struct dc_sink_init_data init_params = {
  6588                          .link = aconnector->dc_link,
  6589                          .sink_signal = SIGNAL_TYPE_VIRTUAL
  6590          };
  6591          struct edid *edid;
  6592  
  6593          /*
  6594           * Note: drm_get_edid gets edid in the following order:
  6595           * 1) override EDID if set via edid_override debugfs,
  6596           * 2) firmware EDID if set via edid_firmware module parameter
  6597           * 3) regular DDC read.
  6598           */
> 6599          if (!edid)
  6600                  edid = drm_get_edid(connector, 
&amdgpu_connector->ddc_bus->aux.ddc);
  6601  
  6602          if (!edid) {
  6603                  DRM_ERROR("No EDID found on connector: %s.\n", 
connector->name);
  6604                  return;
  6605          }
  6606  
  6607          if (drm_detect_hdmi_monitor(edid))
  6608                  init_params.sink_signal = SIGNAL_TYPE_HDMI_TYPE_A;
  6609  
  6610          aconnector->edid = edid;
  6611  
  6612          aconnector->dc_em_sink = dc_link_add_remote_sink(
  6613                  aconnector->dc_link,
  6614                  (uint8_t *)edid,
  6615                  (edid->extensions + 1) * EDID_LENGTH,
  6616                  &init_params);
  6617  
  6618          if (aconnector->base.force == DRM_FORCE_ON) {
  6619                  aconnector->dc_sink = aconnector->dc_link->local_sink ?
  6620                  aconnector->dc_link->local_sink :
  6621                  aconnector->dc_em_sink;
  6622                  dc_sink_retain(aconnector->dc_sink);
  6623          }
  6624  }
  6625  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to