In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' -
'adev->pm.fw' may not be released before return.

Using the function release_firmware() to release adev->pm.fw.

Thus fixing the below:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1571 amdgpu_device_need_post() warn: 
'adev->pm.fw' from request_firmware() not released on lines: 1554.

Cc: Monk Liu <monk....@amd.com>
Cc: Christian König <christian.koe...@amd.com>
Cc: Alex Deucher <alexander.deuc...@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmu...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4b694696930e..f2c3d7ebb218 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1541,11 +1541,11 @@ bool amdgpu_device_need_post(struct amdgpu_device *adev)
                        err = request_firmware(&adev->pm.fw, 
"amdgpu/fiji_smc.bin", adev->dev);
                        /* force vPost if error occured */
                        if (err)
-                               return true;
+                               goto fw_release;
 
                        fw_ver = *((uint32_t *)adev->pm.fw->data + 69);
                        if (fw_ver < 0x00160e00)
-                               return true;
+                               goto fw_release;
                }
        }
 
@@ -1568,6 +1568,8 @@ bool amdgpu_device_need_post(struct amdgpu_device *adev)
        if ((reg != 0) && (reg != 0xffffffff))
                return false;
 
+fw_release:
+       release_firmware(adev->pm.fw);
        return true;
 }
 
-- 
2.34.1

Reply via email to