Not set max fan speed in high performance level because of the fan noise. Best Regards Rex ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Zhu, Rex <rex....@amd.com> Sent: Monday, February 6, 2017 10:09 PM To: Andy Furniss; Alex Deucher Cc: amd-gfx list Subject: RE: [PATCH 4/4] drm/amdgpu: extend profiling mode.
Please see in line. Best Regards Rex -----Original Message----- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent: Monday, February 06, 2017 8:32 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amdgpu: extend profiling mode. Zhu, Rex wrote: > Sorry for the late response. > > Yes, I set the fan speed to max in this patch when user set high performance. > > Considering that: 1. set fan speed to max is helpful to let GPU run under > highest clock as long as possible. > 2. avoid GPU rapid temperature rise in some case. >>OK, I guess you know if it's needed or not. >>It is somewhat annoying noise wise, maybe one day there will be a way for >>users to set fan back on auto? Rex: sure, you can echo "2"> /sys/class/drm/card0/device/hwmon/hwmon3(maybe not 3)/pwm1_enable >>Accepting I don't know how the h/w works your point 2 would imply that with >>perf on auto doing something like running a benchmark that pegs all the >>clocks high should also Rex: based on the thermal, the fan speed.will be dynamically adjusted. >>I don't think that would be popular WRT noise. Rex: maybe I worried unnecessarily. I will change the code not to set fan speed to max. thanks. > > Best Regards > Rex > > > > -----Original Message----- > From: Andy Furniss [mailto:adf.li...@gmail.com] > Sent: Wednesday, February 01, 2017 11:37 PM > To: Alex Deucher > Cc: Zhu, Rex; amd-gfx list > Subject: Re: [PATCH 4/4] drm/amdgpu: extend profiling mode. > > Alex Deucher wrote: >> On Tue, Jan 31, 2017 at 6:19 PM, Andy Furniss <adf.li...@gmail.com> wrote: >>> Andy Furniss wrote: >>>> >>>> Rex Zhu wrote: >>>>> >>>>> in profiling mode, powerplay will fix power state as stable as >>>>> possible.and disable gfx cg and LBPW feature. >>>>> >>>>> profile_standard: as a prerequisite, ensure power and thermal >>>>> sustainable, set clocks ratio as close to the highest clock ratio >>>>> as possible. >>>>> profile_min_sclk: fix mclk as profile_normal, set lowest sclk >>>>> profile_min_mclk: fix sclk as profile_normal, set lowest mclk >>>>> profile_peak: set highest sclk and mclk, power and thermal not >>>>> sustainable >>>>> profile_exit: exit profile mode. enable gfx cg/lbpw feature. >>>> >>>> >>>> Testing R9 285 Tonga on drm-next-4.11-wip >>>> >>>> This commit has the effect that doing >>>> >>>> echo high > >>>> /sys/class/drm/card0/device/power_dpm_force_performance_level >>>> >>>> instantly forces fan to (I guess) max, where normally it doesn't >>>> need anything like as fast with the clocks high when doing nothing else. >>> >>> >>> Ping - just in case this got missed, still the same on current >>> drm-next-4.11-wip >> >> Just a heads up, Rex was looking at this, but it's Chinese New Year this >> week. > > OK, thanks & Happy new year. > > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
From 4e3f4155fac060a4d86d8bff61d461278dd7ac02 Mon Sep 17 00:00:00 2001 From: Rex Zhu <rex....@amd.com> Date: Tue, 7 Feb 2017 17:34:11 +0800 Subject: [PATCH] drm/amd/powerplay: set fan speed to max in profile peak mode only. Change-Id: Ie9e789e6aad0f32841e0dd4229619bc103f702f8 Signed-off-by: Rex Zhu <rex....@amd.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index c72ce85..b1de9e8 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -2624,6 +2624,7 @@ static int smu7_force_dpm_level(struct pp_hwmgr *hwmgr, smu7_force_clock_level(hwmgr, PP_SCLK, 1<<sclk_mask); smu7_force_clock_level(hwmgr, PP_MCLK, 1<<mclk_mask); smu7_force_clock_level(hwmgr, PP_PCIE, 1<<pcie_mask); + break; case AMD_DPM_FORCED_LEVEL_MANUAL: hwmgr->dpm_level = level; @@ -2633,9 +2634,9 @@ static int smu7_force_dpm_level(struct pp_hwmgr *hwmgr, break; } - if (level & (AMD_DPM_FORCED_LEVEL_PROFILE_PEAK | AMD_DPM_FORCED_LEVEL_HIGH)) + if (level == AMD_DPM_FORCED_LEVEL_PROFILE_PEAK && hwmgr->saved_dpm_level != AMD_DPM_FORCED_LEVEL_PROFILE_PEAK) smu7_fan_ctrl_set_fan_speed_percent(hwmgr, 100); - else + else if (level != AMD_DPM_FORCED_LEVEL_PROFILE_PEAK && hwmgr->saved_dpm_level == AMD_DPM_FORCED_LEVEL_PROFILE_PEAK) smu7_fan_ctrl_reset_fan_speed_to_default(hwmgr); return 0; -- 1.9.1
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
