The series is Reviewed-by: Harry Wentland <harry.wentl...@amd.com>
On 2016-12-13 01:41 AM, Dave Airlie wrote:
So whenever I look at DAL I find myself trying to figure out what all of it does, and this leads me to deleting things, so I'm just sending out some stuff that I cleaned today.
We really appreciate the cleanup working while looking at our code. There's still lots to clean up.
One thing I noticed in passing is the displayport code seems possibly endian unsafe, it casts bytes read from hardware into bitfields, this is the best defined behaviour and is generally a pattern we try to steer away from.
Yeah, we generally assume we run on x86. I haven't looked at all the bitfields lately but I do know that we generally use two definitions, one for little, one for big endian, for every bitfield.
The porting the displayport code to use drm defines is the sort of example of a cleanup patch that might cause problems for you in code sharing, but is the exact sort of patch that has been applied to other drivers in the past.
Thanks for the concrete example. I'm still discussing with some guys how exactly we want to deal with this in shared code but am confident this can be done, hence the r-b above.
Harry
Dave. _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
