Am 08.12.2016 um 10:02 schrieb Huang Rui:
On Thu, Dec 08, 2016 at 04:41:04PM +0800, Koenig, Christian wrote:
Sorry, but that just sounds like OS abstraction code which isn't allowed.
There is no benefit except routing all messages through CGS which makes
things much harder to follow.
There isn't COS part at current driver. But it seems to be not good to
introduce COS just for prints. Actually, most of drivers prefer to use
dev_* prints, and it's able to dynamic control the print level when we
debug it.
Well I'm not sure if you have understood what I wanted to say.
The reason that there isn't any COS abstraction is that it isn't allowed
upstream.
Using the dev_* prints in the powerplay code is fine, but don't use the
CGS or any other abstraction layer for them.
So a clear NAK on those patches from my side.
Regards,
Christian.
Thanks,
Ray
Regards,
Christian.
Am 08.12.2016 um 06:23 schrieb Huang Rui:
From: Huang Rui <ray.hu...@amd.com>
Hi all,
These patch set adds the helpers of print in CGS. Powerplay will be
used them instead of raw printk, and we can dynamic change the debug
level with it.
The prefix is like below:
[ 310.200991] amdgpu 0000:01:00.0: [powerplay] ...
Thanks,
Rui
Huang Rui (4):
drm/amdgpu: introduce the cgs print helpers
drm/amd/powerplay: update printk to cgs debug prints for smumgr
drm/amd/powerplay: update printk to cgs debug prints for common part
drm/amd/powerplay: update printk to cgs debug prints for hwmgr
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 26 +++++++++++-
drivers/gpu/drm/amd/include/cgs_common.h | 24 +++++++++++
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 49
+++++++++++-----------
drivers/gpu/drm/amd/powerplay/eventmgr/eventinit.c | 2 +-
drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 26 ++++++------
.../gpu/drm/amd/powerplay/hwmgr/functiontables.c | 14 +++----
drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 8 ++--
drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c | 6 +--
.../amd/powerplay/hwmgr/process_pptables_v1_0.c | 4 +-
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 26 ++++++------
.../gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c | 2 +-
drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 14 +++----
drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 28 ++++++-------
drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c | 4 +-
drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 8 ++--
drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 16 +++----
.../gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c | 2 +-
.../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 +-
.../drm/amd/powerplay/smumgr/polaris10_smumgr.c | 8 ++--
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 16 +++----
drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 14 +++----
.../gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +-
22 files changed, 176 insertions(+), 127 deletions(-)
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
