malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision.
REVISION SUMMARY This patch ports the tests and fixes some issues they had. All tests pass now. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10978 AFFECTED FILES CMakeLists.txt src/importers/itunes/ITunesTrack.cpp tests/CMakeLists.txt tests/TestAmarok.cpp tests/TestCaseConverter.cpp tests/TestEngineController.cpp tests/TestExpression.cpp tests/TestQStringx.cpp tests/TestSmartPointerList.cpp tests/TestTagGuesser.cpp tests/TestTrackOrganizer.cpp tests/amarokurls/CMakeLists.txt tests/amarokurls/TestAmarokUrls.cpp tests/browsers/CMakeLists.txt tests/browsers/TestSingleCollectionTreeItemModel.cpp tests/browsers/TestSingleCollectionTreeItemModel.h tests/context/engines/CMakeLists.txt tests/context/engines/similarartists/CMakeLists.txt tests/context/engines/similarartists/TestSimilarArtistsEngine.cpp tests/context/engines/upcomingevents/CMakeLists.txt tests/context/engines/upcomingevents/TestUpcomingEventsEngine.cpp tests/core-impl/collections/aggregate/CMakeLists.txt tests/core-impl/collections/aggregate/TestAggregateMeta.cpp tests/core-impl/collections/db/sql/CMakeLists.txt tests/core-impl/collections/db/sql/TestDatabaseUpdater.cpp tests/core-impl/collections/db/sql/TestDatabaseUpdater.h tests/core-impl/collections/db/sql/TestSqlAlbum.cpp tests/core-impl/collections/db/sql/TestSqlAlbum.h tests/core-impl/collections/db/sql/TestSqlArtist.cpp tests/core-impl/collections/db/sql/TestSqlArtist.h tests/core-impl/collections/db/sql/TestSqlCollection.cpp tests/core-impl/collections/db/sql/TestSqlCollection.h tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp tests/core-impl/collections/db/sql/TestSqlCollectionLocation.h tests/core-impl/collections/db/sql/TestSqlQueryMaker.cpp tests/core-impl/collections/db/sql/TestSqlQueryMaker.h tests/core-impl/collections/db/sql/TestSqlScanManager.cpp tests/core-impl/collections/db/sql/TestSqlScanManager.h tests/core-impl/collections/db/sql/TestSqlTrack.cpp tests/core-impl/collections/db/sql/TestSqlTrack.h tests/core-impl/collections/support/CMakeLists.txt tests/core-impl/collections/support/TestArtistHelper.cpp tests/core-impl/collections/support/TestMemoryQueryMaker.cpp tests/core-impl/logger/CMakeLists.txt tests/core-impl/logger/TestProxyLogger.cpp tests/core-impl/meta/cue/CMakeLists.txt tests/core-impl/meta/cue/TestCueFileSupport.cpp tests/core-impl/meta/file/CMakeLists.txt tests/core-impl/meta/file/TestMetaFileTrack.cpp tests/core-impl/meta/file/TestMetaFileTrack.h tests/core-impl/meta/multi/CMakeLists.txt tests/core-impl/meta/multi/TestMetaMultiTrack.cpp tests/core-impl/playlists/types/file/CMakeLists.txt tests/core-impl/playlists/types/file/TestPlaylistFileSupport.cpp tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.h tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.cpp tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.h tests/core-impl/playlists/types/file/xspf/TestXSPFPlaylist.cpp tests/core-impl/playlists/types/file/xspf/TestXSPFPlaylist.h tests/core-impl/support/CMakeLists.txt tests/core-impl/support/TestTrackLoader.cpp tests/core/capabilities/CMakeLists.txt tests/core/capabilities/TestActionsCapability.cpp tests/core/capabilities/TestActionsCapability.h tests/core/collections/CMakeLists.txt tests/core/collections/CollectionLocationTest.cpp tests/core/collections/TestCollection.cpp tests/core/collections/TestQueryMaker.cpp tests/core/collections/TestQueryMaker.h tests/core/collections/support/CMakeLists.txt tests/core/collections/support/TestTrackForUrlWorker.cpp tests/core/interfaces/CMakeLists.txt tests/core/interfaces/TestMetaCapability.cpp tests/core/meta/CMakeLists.txt tests/core/meta/TestMetaTrack.cpp tests/core/meta/support/CMakeLists.txt tests/core/meta/support/TestMetaAlbumKey.cpp tests/core/meta/support/TestMetaConstants.cpp tests/core/meta/support/TestMetaTrackKey.cpp tests/core/meta/support/TestPrivateMetaRegistry.cpp tests/core/playlists/CMakeLists.txt tests/core/playlists/TestPlaylistFormat.cpp tests/core/playlists/TestPlaylistObserver.cpp tests/dynamic/CMakeLists.txt tests/dynamic/TestDynamicModel.cpp tests/dynamic/TestTrackSet.cpp tests/importers/ImporterMocks.cpp tests/importers/TestAmarokImporter.cpp tests/importers/TestBansheeImporter.cpp tests/importers/TestClementineImporter.cpp tests/importers/TestFastForwardImporter.cpp tests/importers/TestITunesImporter.cpp tests/importers/TestImporterBase.cpp tests/importers/TestImporterBase.h tests/importers/TestImporterManager.cpp tests/importers/TestImporterManager.h tests/importers/TestImporterProvider.cpp tests/importers/TestRhythmboxImporter.cpp tests/importers/TestSimpleImporterConfigWidget.cpp tests/playlist/CMakeLists.txt tests/playlist/TestPlaylistModels.cpp tests/playlistmanager/file/TestPlaylistFileProvider.cpp tests/playlistmanager/sql/TestSqlUserPlaylistProvider.cpp tests/scanner/CMakeLists.txt tests/scanner/TestGenericScanManager.cpp tests/scanner/TestGenericScanManager.h tests/synchronization/CMakeLists.txt tests/synchronization/TestMasterSlaveSynchronizationJob.cpp tests/synchronization/TestOneWaySynchronizationJob.cpp tests/synchronization/TestUnionJob.cpp tests/timecode/CMakeLists.txt tests/timecode/TestTimecodeTrackProvider.cpp To: malteveerman, #amarok Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker
