----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130142/#review103864 -----------------------------------------------------------
Ship it! I tested it and integrated it. - Stefano Pettini On May 26, 2017, 2:22 a.m., Russell Andres wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130142/ > ----------------------------------------------------------- > > (Updated May 26, 2017, 2:22 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > Working AAC format detection and transcoding option. I have to admit that > most of this work was done by a helpful user on the Ubuntu forums, but I have > tested the patch. See > https://ubuntuforums.org/showthread.php?t=2348624&page=2&p=13642704#post13642704 > for the original discovery of the bug. It is also on the Amarok bug list at > https://bugs.kde.org/show_bug.cgi?id=374670#c11 > > > Diffs > ----- > > src/core/transcoding/formats/TranscodingAacFormat.cpp 7dcd4cf > > > Diff: https://git.reviewboard.kde.org/r/130142/diff/1/ > > > Testing > ------- > > I patched Amarok 2.8.4 and then compiled Amarok. I then tested to see if AAC > transcoding worked. The option appeared and it did indeed transcode to AAC > format. I also updated the patch to work with the latest version from Git > here at KDE (however the patch had been created, it was not in git format). > > > Thanks, > > Russell Andres > >
