----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130232/ -----------------------------------------------------------
(Updated Авг. 19, 2017, 11:06 д.п.) Review request for Amarok. Summary (updated) ----------------- Fix crash during musicbrainz search Bugs: 328359 https://bugs.kde.org/show_bug.cgi?id=328359 Repository: amarok Description ------- + Fixed search result appending process to prevent creation of invalid indices. + Added "Accept" header to musicbrainz request, because sometimes MusicBrainz returns response in JSON format instead of XML. Diffs ----- src/musicbrainz/MusicBrainzFinder.h beb155166f src/musicbrainz/MusicBrainzFinder.cpp 9a1b3bb14a src/musicbrainz/MusicBrainzTagsItem.h 6852c9fd31 src/musicbrainz/MusicBrainzTagsItem.cpp 0941a901bc src/musicbrainz/MusicBrainzTagsModel.h eaee7f8e90 src/musicbrainz/MusicBrainzTagsModel.cpp 0ffb284055 src/musicbrainz/MusicBrainzXmlParser.h c7f9e72c0e src/musicbrainz/MusicBrainzXmlParser.cpp 290a275aed Diff: https://git.reviewboard.kde.org/r/130232/diff/ Testing ------- Thanks, Sergey Ivanov