----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129920/ -----------------------------------------------------------
(Updated Feb. 5, 2017, 8:16 p.m.) Review request for Amarok. Summary (updated) ----------------- Replace Deprecated AV Functions (fix bug 362409) Repository: amarok Description ------- Replace all deprecated (and not found) functions with their new counterpart. At least `avcodec_alloc_frame()` and `avcodec_get_frame_defaults()` must be replaced with `av_frame_alloc()` and `av_frame_unref()` respectively as those cause the compile to crash otherwise. `av_free_packet()` should also be replaced with `av_packet_unref()` Replacing how pCodecCdx is obtained should also be fine. My only concerns are with replacing `avcodec_decode_audio4()` as this has become quite more complicated and I cannot currently test its functionality as getting tags from musicbrainz fails before it reaches this code. See [bug 328359](https://bugs.kde.org/show_bug.cgi?id=328359) Diffs ----- src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b4fc Diff: https://git.reviewboard.kde.org/r/129920/diff/ Testing ------- Thanks, Dominik Waurenschk
