> On Feb. 2, 2016, 6:34 a.m., Matthias Berndt wrote: > > Ship It! > > Myriam Schweingruber wrote: > erm, you can't call ship it on your own requests, that would counteract > the sense of the review request :-) > > Albert Astals Cid wrote: > I suggest you create a new review request, reviewers will easily skip > reviews marked as "ship it" as they'll think someone else has already > reviewed it. > > Matthias Berndt wrote: > I can't be bothered, Amarok appears to be dead anyway. Besides, the whole > model of having a collection of audio files you listen to seems to me anyway. > E. g. Deezer has a wider selection of music than I could ever hope to amass, > so what's the point?
Ok, i'll discard the review on your behalf then. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126195/#review91915 ----------------------------------------------------------- On Nov. 28, 2015, 10:04 p.m., Matthias Berndt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126195/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2015, 10:04 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > Currently in the tag guessing dialog a coloured version of the file name > is shown. The colours indicate where the individual tag values are taken > from. If any of the tag values appears twice in the file name, both > occurrences are coloured, even though only one should be, i. e. the one > he tag value is actually being derived from. This patch fixes this issue > > > Diffs > ----- > > shared/TagsFromFileNameGuesser.h 0aa94c5 > shared/TagsFromFileNameGuesser.cpp 1152271 > src/dialogs/TagDialog.cpp 54e8957 > src/dialogs/TagGuesser.h 55f5bfd > src/dialogs/TagGuesser.cpp 5b3267f > src/dialogs/TagGuesserDialog.h 2c1a753 > src/dialogs/TagGuesserDialog.cpp e6c427e > tests/TestTagGuesser.cpp 620ff98 > > Diff: https://git.reviewboard.kde.org/r/126195/diff/ > > > Testing > ------- > > > Thanks, > > Matthias Berndt > >
