----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129055/ -----------------------------------------------------------
(Updated Oct. 24, 2016, 5:43 a.m.) Status ------ This change has been marked as submitted. Review request for Amarok. Changes ------- Submitted with commit 0b2b243b2b70471c32d282157624379da5214051 by Alexandr Akulich to branch kf5. Repository: amarok Description ------- There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 : ```diff setText( i18n( "Play/Pause" ) ); - setShortcut( Qt::Key_Space ); - setGlobalShortcut( KShortcut() ); + KGlobalAccel::setGlobalShortcut(this, QKeySequence(Qt::Key_Space) ); ``` The change globally binds Key_Space, which breaks the key usage for the session. Diffs ----- src/ActionClasses.cpp 77334fc Diff: https://git.reviewboard.kde.org/r/129055/diff/ Testing ------- Compiles. Thanks, Alexandr Akulich