> On July 17, 2016, 12:05 p.m., Kai Uwe Broulik wrote: > > Can we just KAboutData desktopFileName or something like that? I fear when > > it gets renamed to org.kde.amarok at one point it'll break again.
When/if amarok is ported to kf5, but kde4's KABoutData doesn't support desktopFileName (as far as I can tell). - Rex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128418/#review97494 ----------------------------------------------------------- On July 10, 2016, 10:12 a.m., Antonio Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128418/ > ----------------------------------------------------------- > > (Updated July 10, 2016, 10:12 a.m.) > > > Review request for Amarok. > > > Bugs: 365275 > https://bugs.kde.org/show_bug.cgi?id=365275 > > > Repository: amarok > > > Description > ------- > > According to the MPRIS2 spec, the DesktopEntry value should be "the basename > of the .desktop file" [1], not the desktop-file-id. So for amarok it should > be "amarok" and not "kde4-amarok", regardless of where the desktop file is > installed. This fixes displaying MPRIS controls in the Amarok taskbar tooltip > in Plasma 5.7 > > [1] > https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry > > > Diffs > ----- > > src/dbus/mpris2/MediaPlayer2.cpp cbe1a2a > > Diff: https://git.reviewboard.kde.org/r/128418/diff/ > > > Testing > ------- > > Player controls are displayed again in the Amarok taskbar tooltip in Plasma > 5.7. > > > Thanks, > > Antonio Rojas > >
