-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128245/
-----------------------------------------------------------
(Updated July 10, 2016, 11:04 p.m.)
Review request for Amarok.
Changes
-------
Rebased and updated changelog, please merge to master.
Bugs: 341661
https://bugs.kde.org/show_bug.cgi?id=341661
Repository: amarok
Description
-------
Every numeric field, like length, disc number and track number, were not
properly parsed by the filter dialog or by the dynamic playlist dialog into the
textual query string used to then apply the filter.
The bug was due to what sounds like an "optimization" that swapped the first
and second value of a "between" condition, to make sure the smaller value was
always the first value and the larger always the second. The problem was that
this was applied also to non-between conditions, actually swapping the lenth or
disc number with 0, making 0 appear in the textual representation of the
condition.
The fix makes sure that "optimization" is applied only in case of actual
"between" conditions, leaving the values "unoptimized" for any other kind of
condition (=, <, > and similar).
Diffs (updated)
-----
ChangeLog 23599f1
src/widgets/MetaQueryWidget.cpp abce6b7
Diff: https://git.reviewboard.kde.org/r/128245/diff/
Testing
-------
Verified in both filter dialog and dynamic playlist dialog.
Thanks,
Stefano Pettini
