> On June 20, 2016, 10:27 p.m., Matěj Laitl wrote: > > Looks well, one minor thing below - unrelated change. > > > > Also please mention: > > BUG: 348313 > > ..in the commit message and include a ChangeLog entry in the patch. > > Olivier Churlaud wrote: > What is a changelog entry? > > If I call the commit: > ``` > Disable SSL in wikipedia applet. > REVIEW: 128248 > BUG: 348313 > ``` > is it ok or is something missing?
Nevermind I got it. - Olivier ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/#review96755 ----------------------------------------------------------- On June 21, 2016, 12:17 a.m., Olivier Churlaud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128248/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 12:17 a.m.) > > > Review request for Amarok and Myriam Schweingruber. > > > Bugs: 349313 > https://bugs.kde.org/show_bug.cgi?id=349313 > > > Repository: amarok > > > Description > ------- > > I removed every possibility to use non SSL links > > > Diffs > ----- > > src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 > src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df > src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc > src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b > > Diff: https://git.reviewboard.kde.org/r/128248/diff/ > > > Testing > ------- > > It compiles. However not tested, because make install always install in > /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to > mess my install. > > > Thanks, > > Olivier Churlaud > >
