----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127458/ -----------------------------------------------------------
(Updated June 18, 2016, 12:08 a.m.) Review request for Amarok. Summary (updated) ----------------- Fix for warnings, one of them a probable bug Repository: amarok Description (updated) ------- This fixes some minor C++ warnings: one unused variable and another one about operator precedence. However I think the last one was I bug, that I think I fixed. It was about bpm in SqlScanProcessor. In addition, some warnings regarding deprecated functions are addressed. Diffs ----- src/configdialog/dialogs/DatabaseConfig.cpp 1cb2d97 src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp ea9c911 src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp 5cdb693 src/services/mp3tunes/harmonydaemon/Mp3tunesHarmonyDaemon.cpp 5b09f07 src/services/mp3tunes/libmp3tunes/harmony.c ead0345 src/statemanagement/DefaultApplicationController.cpp 5886789 Diff: https://git.reviewboard.kde.org/r/127458/diff/ Testing ------- Thanks, Stefano Pettini